[next] .github: Add pull request template#719
Merged
chaitu236 merged 1 commit intoni:nilrt/master/nextfrom Aug 20, 2024
Merged
Conversation
Add a Github PR template to help contributors write high-quality PRs correctly the first time. Signed-off-by: Alex Stewart <alex.stewart@ni.com>
chaitu236
requested changes
Aug 19, 2024
Contributor
chaitu236
left a comment
chaitu236
left a comment
There was a problem hiding this comment.
Can we move this to under docs directory? Or is there a reason we'd want to keep it hidden in .github directory?
Contributor
Author
|
chaitu236
approved these changes
Aug 20, 2024
Contributor
|
Cherry-picked to nilrt/master/kirkstone |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Github PR template to help contributors write high-quality PRs correctly the first time.
Testing
I don't know how to test this. Opening a new PR against my dev branch doesn't prompt with the template. But this is basically just a copy of what we have been using in the nilrt-snac repo.